Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump graphql dependency #25

Merged
merged 4 commits into from
Dec 17, 2017
Merged

Conversation

adamvr
Copy link
Contributor

@adamvr adamvr commented Oct 5, 2017

Introduction

This pull requests bumps the graphql dependency version to ^0.11.7. The primary motivation for this pull request is that the newer versions of graphql-js are not backwards compatible and cause fun, difficult to trace problems such as those described here.

Changes

No functional changes, but the following modifications were made to make joiql comply with the newer version of graphql:

  • Resolvers are stripped from input types. I assume that graphql was ignoring them previously and now throws an error if they are provided.
  • fieldASTs in the opts / info / fourth argument to resolve has been renamed to fieldNodes.

@craigspaeth
Copy link
Collaborator

Sorry for the really long delay in seeing this—I need to update my notification settings. LGTM, thanks for the PR!

@craigspaeth craigspaeth merged commit accbdb2 into muraljs:master Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants